-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot Use in Google App Engine Due to Unsafe Package #52
Comments
zenazn
added a commit
that referenced
this issue
Jul 28, 2014
App Engine disallows package unsafe. As a workaround for the (unsafe) RCU atomic pointer shenanigans we pull in order to avoid taking a lock in the hot routing path, let's just grab the lock. Honestly, I doubt anyone will notice anyways, especially considering the fact that App Engine is single-threaded anyways. Fixes #52.
Bam! (I should mention up front that I don't have an App Engine instance handy, so I haven't actually tested this. It looks plausible though!) |
Thanks so much! I'd be happy to run some tests on it once we get it up and running. However, seems like the use of the syscall package is also not allowed. Is it possible to refactor around that as well? |
zenazn
added a commit
that referenced
this issue
Aug 23, 2014
Sorry about the delay here: should be fixed! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would like to use Goji for a project hosted on Google App Engine. Unfortunately, Google App Engine does not support the unsafe package (link).
Is it possible to refactor the router to not have to use the unsafe package? This would open Gojil up for developers on Google App Engine.
The text was updated successfully, but these errors were encountered: