Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code to run on Powersystem #203

Closed
wants to merge 1 commit into from

Conversation

genisysram
Copy link

Hi
Here is my contribution to your code, its working good on powersystems.

Thanks for the code, its working good.

What do these changes do?

Added Architecture "ppc64le"

Are there changes in behavior for the user?

No

Related issue number

No

@zenazn
Copy link
Owner

zenazn commented Dec 1, 2020

Thanks for your contribution! Since Goji doesn't do anything architecture-specific, I'm going to keep CI on its default architecture to make it faster. Happy to revisit this decision if we ever see a regression on another architecture, though.

It's good to hear it works on ppc though!

@zenazn zenazn closed this Dec 1, 2020
@genisysram
Copy link
Author

This also ensures that whatever versions of go you are using is complete and supports all features on ppc64le. And, it is possible for go programs to be architecture dependent - if someone ever adds a dependency on the hardware, expected or not, this will ensure that the project will always build when it gets to the distros - if not, the distro porting team winds up picking up the work which can be painful to those coming in from outside the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants