-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp to do expiration check entirely in Dynamo to avoid extra GETs/… #23
Conversation
…DELETEs; add ability to add a cutoff time; redo tests to match
OK I've stared at this long enough that I'm confident I understand this, and I'm happy with the new behaviour (and it works great in tests elsewhere). However, since I've pushed a bunch of commits to this PR, I'm going to tag it for review from another set of eyes before merging. |
"github.com/zencoder/ddbsync" | ||
) | ||
|
||
func main() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this used when we want to manually unlock or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be, but I believe the original purpose is to facilitiate manual testing in addition to the unit tests. At least, that's what I've used it for...
…DELETEs; add ability to add a cutoff time; redo tests to match
Previously the Lock's workflow was:
Updated to