RBENV_DIR in builds

[viraptor]

I've run into an unexpected Samson behaviour.

When running a ruby script inside the deployment actions, RBENV_DIR is inherited from Samson's runtime in my deployment. That means anything expecting the right ruby to be set via .ruby-version will fail :(

While the fix is easy (unset RBENV_DIR at the beginning of the build), it needs to be done for every project separately and all teams need to learn about it. It would be great if I could configure Samson to drop some environment variables globally. For example never pass the RBENV_DIR / PATH / RAILS_ENV / HOME to the jobs it's running.

[grosser]

whitelisted env vars are defined here:

https://github.com/zendesk/samson/blob/master/app/models/terminal_executor.rb#L166-L175

we might be able to remove RBENV_DIR ...
PATH needs to stay or nothing works like ls etc
RAILS_ENV etc is already not passed in

[grosser]

keep these issues coming ... such a basic flaw that we never addresses since we added that into our base commands years ago :D