Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to deploy while global lock is on causes exceptions #3864

Closed
viraptor opened this issue Sep 29, 2020 · 3 comments · Fixed by #3865
Closed

Trying to deploy while global lock is on causes exceptions #3864

viraptor opened this issue Sep 29, 2020 · 3 comments · Fixed by #3865

Comments

@viraptor
Copy link
Contributor

viraptor commented Sep 29, 2020

When trying to deploy while the global lock is on, I get an exception: (in v3222)

PG::NotNullViolation:

ERROR:  null value in column "job_id" violates not-null constraint
DETAIL:  Failing row contains (44710, 5, null, v370, 2020-09-29 06:27:39.747704, 2020-09-29 06:27:39.747704, null, null, null, t, 4, t, f).

at

...
File /home/ubuntu/samson/app/models/stage.rb line 95 in create_deploy
File /home/ubuntu/samson/app/models/deploy_service.rb line 16 in deploy
File /home/ubuntu/samson/app/controllers/deploys_controller.rb line 57 in create 
@grosser
Copy link
Contributor

grosser commented Sep 30, 2020

oh man ... this is soo old :D
#215 added it ...

so basically this is a feature to block 1-off jobs when things are globally locked I think
but it makes sense that whoever did the locking should be able to still deploy

@grosser
Copy link
Contributor

grosser commented Sep 30, 2020

fixed by #3865

@viraptor
Copy link
Contributor Author

Awesome work. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants