Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and restructure #40

Open
zdrve opened this issue Apr 29, 2024 · 3 comments
Open

Rename and restructure #40

zdrve opened this issue Apr 29, 2024 · 3 comments

Comments

@zdrve
Copy link
Contributor

zdrve commented Apr 29, 2024

Rename the repository to check-codeowners (I have created https://github.com/zendesk/check-codeowners to reserve the name until we do this).

Provide a second GitHub Action, to actually perform the check, not just install the script.

It would be nice if these both were valid:

Install, then run:

    - name: Install the check-codeowners script
      uses: zendesk/check-codeowners/install@v123
    - name: Check codeowners
      run: check-codeowners --strict --find-no-matches --check-unowned

Run, without installing:

    - name: Check codeowners
      uses: zendesk/check-codeowners@v123
      with:
        options: --strict --find-no-matches --check-unowned

or even:

    - name: Check codeowners
      uses: zendesk/check-codeowners@v123
      with:
        strict: "true"
        find-no-matches: "true"
        check-unowned: "true"

(though that last variant then makes it hard to know what command one may run at the shell, in order to match what the action does. Perhaps in this case the action could print the equivalent shell command to stderr).

@zdrve
Copy link
Contributor Author

zdrve commented Apr 29, 2024

cc @grosser

@grosser
Copy link
Contributor

grosser commented Apr 29, 2024

yeah v2 is nicest 👍

@grosser
Copy link
Contributor

grosser commented Apr 29, 2024

... but v1 is good enough and easy to copy-paste 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants