Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename findTwicket() to findTwitterTicketStatus() #367

Closed
OAFCROB opened this issue Dec 6, 2017 · 3 comments
Closed

Rename findTwicket() to findTwitterTicketStatus() #367

OAFCROB opened this issue Dec 6, 2017 · 3 comments

Comments

@OAFCROB
Copy link

OAFCROB commented Dec 6, 2017

Should [findTwicket()|https://github.com/zendesk/zendesk_api_client_php/blob/master/src/Zendesk/API/Resources/Core/Tickets.php#L116] be rename to be a bit more descriptive to something like findTwitterTicketStatus() as it's not obvious to what it's doing. Or put in an @see https://developer.zendesk.com/rest_api/docs/core/twitter_channel#getting-twicket-status.

At a glance it looks like there is a spelling mistake for this and it should be findTicket but after reading the comments I understood what it was doing. However, when comparing that to the Zendesk API documentation this is getting the [statuses|https://developer.zendesk.com/rest_api/docs/core/twitter_channel#getting-twicket-status.]

I also couldn't find an test coverage for this method. I would be happy to look into making the change, but wanted to see if this is something that would be of interest.

@joseconsador
Copy link
Contributor

Hi @OAFCROB ,
That is correct, looks like this method was not updated when we switched to v2. Of course, pull requests are always welcome

@OAFCROB
Copy link
Author

OAFCROB commented Oct 25, 2018

@joseconsador sorry I totally missed this, put in a PR for the change.

@donjose24
Copy link
Contributor

Hello! the findTwicket was intended. these are tickets that originated from twitter

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants