Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(modals): upgrade container-modal #1054

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Conversation

hzhu
Copy link
Contributor

@hzhu hzhu commented Mar 23, 2021

Description

Upgrades @zendeskgarden/container-modal to latest version. This addresses a bug where choosing a Select option within a modal dismisses the modal.

Detail

Verified locally that choosing a Select option within a modal no longer dismisses the modal.

Checklist

  • πŸ‘Œ design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🀘 renders as expected with Bedrock CSS (?bedrock)
  • β™Ώ analyzed via axe and evaluated using VoiceOver
  • πŸ’‚β€β™‚οΈ includes new unit tests
  • πŸ“ tested in Chrome, Firefox, Safari, Edge, and IE11

@hzhu hzhu self-assigned this Mar 23, 2021
@hzhu hzhu requested a review from a team as a code owner March 23, 2021 19:06
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.149% when pulling 6fe878e on hzhu/modals-container-upgrade into 52e80f7 on main.

@zendesk-garden zendesk-garden temporarily deployed to staging March 23, 2021 19:32 Inactive
@hzhu hzhu merged commit 5b0a855 into main Mar 23, 2021
@hzhu hzhu deleted the hzhu/modals-container-upgrade branch March 23, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants