Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theming): enhance focus utilities with additional parameter overrides #1549

Merged
merged 3 commits into from
May 10, 2023
Merged

feat(theming): enhance focus utilities with additional parameter overrides #1549

merged 3 commits into from
May 10, 2023

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented May 10, 2023

Description

  • feat: add boxShadow retention to getFocusBoxShadow
  • fix: prevent focusStyles from overriding existing styles: { boxShadow: ... }
  • feat: add spacerHue and spacerShade color overrides to getFocusBoxShadow and focusStyles

@jzempel jzempel requested a review from a team as a code owner May 10, 2023 14:11
@coveralls
Copy link

coveralls commented May 10, 2023 •
edited
Loading

Coverage Status

Coverage: 96.152% (+0.002%) from 96.15% when pulling 15d9180 on jzempel/fix-box-shadow into 6cdbddc on main.

@jzempel jzempel merged commit 4dd4c7a into main May 10, 2023
@jzempel jzempel deleted the jzempel/fix-box-shadow branch May 10, 2023 15:05
@jzempel jzempel mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Francois-Esquire Francois-Esquire Francois-Esquire approved these changes

Assignees
No one assigned
Labels
PR: New Feature 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jzempel @coveralls @Francois-Esquire @zendesk-garden