feat(tags): new light/dark mode colors #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze-flo
approved these changes
May 23, 2024
| @@ -6,8 +6,8 @@ | |||
| */ | |||
|
|
|||
| import React from 'react'; | |||
| import { render, renderRtl } from 'garden-test-utils'; | |||
| import { PALETTE, getColorV8 } from '@zendeskgarden/react-theming'; | |||
| import { render, renderDark, renderRtl } from 'garden-test-utils'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verified the following in both light and dark modes:
<Tag><Tag hue="grey">and<Tag hue="neutralHue"><Tag hue="blue">and<Tag hue="primaryHue"><Tag hue="red">and<Tag hue="dangerHue"><Tag hue="green">and<Tag hue="successHue"><Tag hue="yellow">and<Tag hue="warningHue"><Tag hue="azure"><Tag hue="lemon"><Tag hue="#FD5A1E">Detail
Note there are two outstanding questions with design:
<Tag hue="grey">Tag.ClosebuttonNote that when testing with Storybook, a string can be manually entered into the
huecolor picker – often resulting in an error. Simply click the "Remount component" button in the toolbar once you've entered the correct value.Checklist
npm start)renders as expected with reversed (RTL) direction?bedrock)tested in Chrome, Firefox, Safari, and Edge