Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dropdowns): allow object values for NextItem selection #817

Merged
merged 1 commit into from
Jul 22, 2020
Merged

fix(dropdowns): allow object values for NextItem selection #817

merged 1 commit into from
Jul 22, 2020

Conversation

austingreendev
Copy link
Contributor

@austingreendev austingreendev commented Jul 22, 2020 •
edited
Loading

Description

Fixes #816

This PR allows NextItem component to handle keyboard navigation correctly when the provided value is an object.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@austingreendev austingreendev requested a review from a team July 22, 2020 16:28
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.281% when pulling 656574c on agreen/next-item-arrow-navigation into 5118756 on main.

@zendesk-garden zendesk-garden temporarily deployed to staging July 22, 2020 17:06 Inactive
@austingreendev austingreendev merged commit e61d3e5 into main Jul 22, 2020
@austingreendev austingreendev deleted the agreen/next-item-arrow-navigation branch July 22, 2020 18:00
@austingreendev austingreendev mentioned this pull request Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzhu hzhu hzhu approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropdown NextItem Components Do Not Work Properly When Passed Object Values
4 participants
@austingreendev @coveralls @hzhu @zendesk-garden