Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): migrate react-buttons to storybook #889

Merged
merged 8 commits into from
Oct 7, 2020
Merged

chore(docs): migrate react-buttons to storybook #889

merged 8 commits into from
Oct 7, 2020

Conversation

hzhu
Copy link
Contributor

@hzhu hzhu commented Sep 24, 2020 •
edited
Loading

Description

This PR migrates the examples in Styleguidst to Storybook.

Details

Some addon-a11y warnings for downshift exist for Splitbutton Story 😔 .

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@hzhu hzhu self-assigned this Sep 24, 2020
@coveralls
Copy link

coveralls commented Sep 24, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 95.84% when pulling c3686a0 on hzhu/storybook-buttons into 4c2407e on main.

@zendesk-garden zendesk-garden temporarily deployed to staging September 24, 2020 17:20 Inactive
@hzhu hzhu marked this pull request as ready for review September 24, 2020 21:06
@hzhu hzhu requested a review from a team as a code owner September 24, 2020 21:06
@zendesk-garden zendesk-garden temporarily deployed to staging September 24, 2020 21:32 Inactive
@zendesk-garden zendesk-garden temporarily deployed to staging September 25, 2020 20:35 Inactive
jzempel
jzempel requested changes Sep 29, 2020
View reviewed changes
packages/buttons/stories/2-Button.stories.tsx Show resolved Hide resolved
packages/buttons/stories/3-Anchor.stories.tsx Outdated Show resolved Hide resolved
packages/buttons/stories/4-ButtonGroup.stories.tsx Outdated Show resolved Hide resolved
packages/buttons/stories/5-ChevronButton.stories.tsx Show resolved Hide resolved
packages/buttons/stories/6-IconButton.stories.tsx Show resolved Hide resolved
packages/buttons/stories/6-IconButton.stories.tsx Show resolved Hide resolved
packages/buttons/stories/7-SplitButton.stories.tsx Show resolved Hide resolved
packages/buttons/stories/7-SplitButton.stories.tsx Outdated Show resolved Hide resolved
packages/buttons/stories/8-ToggleButton.stories.tsx Outdated Show resolved Hide resolved
packages/buttons/stories/9-ToggleIcon.stories.tsx Show resolved Hide resolved
@zendesk-garden zendesk-garden temporarily deployed to staging September 29, 2020 21:06 Inactive
@zendesk-garden zendesk-garden temporarily deployed to staging September 30, 2020 23:14 Inactive
@zendesk-garden zendesk-garden temporarily deployed to staging October 5, 2020 21:46 Inactive
@zendesk-garden zendesk-garden temporarily deployed to staging October 5, 2020 22:55 Inactive
@jzempel jzempel mentioned this pull request Oct 6, 2020
Merged
7 tasks
@zendesk-garden zendesk-garden temporarily deployed to staging October 7, 2020 17:55 Inactive
@hzhu hzhu merged commit 5dc6ba5 into main Oct 7, 2020
@hzhu hzhu deleted the hzhu/storybook-buttons branch October 7, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austingreendev austingreendev austingreendev approved these changes

@jzempel jzempel jzempel approved these changes

Assignees

@hzhu hzhu

Labels
PR: Docs 📝
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hzhu @coveralls @jzempel @austingreendev @zendesk-garden