fix(slider): prevent default screenreader cursor navigation #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgorfine-zendesk
approved these changes
Oct 13, 2022
packages/slider/src/useSlider.ts
Outdated
| @@ -225,6 +225,7 @@ export function useSlider<T extends Element = Element, M extends HTMLElement = H | |||
| } | |||
|
|
|||
| if (value !== undefined) { | |||
| event.preventDefault(); // prevent screenreader navigation | |||
There was a problem hiding this comment.
Suggested change
| event.preventDefault(); // prevent screenreader navigation | |
| event.preventDefault(); // avoid screenreader behavior that hinders keyboard navigation |
nit: Mind tweaking the wording here a little? I don't think we want to give the impression that we're making this inaccessible to screen readers. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The initial port over from
react-componentsmissed theevent.preventDefault()call on keyboard interactions.Detail
The fix was tested against zendeskgarden/react-components#1431.
Checklist
demo is up-to-date (yarn start)includes new unit tests