This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
Refactor ZFTool to use ZendDiagnostics #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Thinkscape
commented
Aug 24, 2013
Thinkscape
commented
- Set zendframework/ZendDiagnostics as dependency in composer.json.
- Move all tests to new repo except MVC tests.
- Naming/labeling logic - make it internal to Test\Runner.
- Create a compatibility layer
- Understand and consume universal tests by default.
- Update docs!
…eature/zend-diagnostics-refactor
- Add support for skipped checks. - s/test/check/ - Update docs. - Refactor usage of console param aliases after the fix in ZF 2.2+. - Fix checks filtering. - Fix unit tests leaking diagnostic reporter output. - Fix composer.json import of ZendDiagnostics.
|
Ready for review @lsmith77 @weierophinney. This PR is a refactor for recently-released ZendDiagnostics 1.0 and de-duplicates elements of It also adds support for missing features that were added to ZendDiagnostics in the past few months (i.e. skipped checks) and updates documentation to be in line with all the changes. Previous functionality has been re-factored and works the same as it used to. |
This was referenced Mar 8, 2014
Closed
| if ($checkGroupName) { | ||
| $config = array_intersect_ukey($config, array($checkGroupName => 1), 'strcasecmp'); | ||
|
|
||
| if(empty($config)) { |
|
Just skimmed over it .. didn't not attempt to run the code but added some comments as per your request :) |
|
Thanks! |
Thinkscape
added a commit
that referenced
this pull request
Mar 31, 2014
Refactor ZFTool to use ZendDiagnostics.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.