This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Complete #14 #37
Merged
Complete #14 #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses ternary operator to set values instead of if/else. - Extracts logic for retrieving adapter from authentication service to its own method, and then uses ternary operator to assign adapter. - Refactors some conditional statements to move nested logic into the main workflow.
- license docblock - Adds docblock to authenticate() method) - makes property private
weierophinney
force-pushed
the
feature/14-authentication-validator-consume-service
branch
from
f633cfc to
eca04ec
Compare
weierophinney
deleted the
feature/14-authentication-validator-consume-service
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch incorporates feedback provided on #14; I was unable to push to the author's repository, so I am instead opening a new pull request.
The patch incorporates all changes in #14, plus some changes recommended and/or required on review.
What the patch accomplishes is the ability for a
Zend\Authentication\Validator\Authenticationto use the authentication adapter in the composedAuthenticationServiceinstance when:ValidatableAdapterInterfaceinstanceThis simplifies usage, as the consumer of the validator no longer needs direct access to the authentication adapter.