Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Fix unused private $tz, add missing $utc private properties #190

Merged

Conversation

adrian-martinez-interactiv4
Copy link
Contributor

In code constructor, $this->utc referenced a non-existing property; at the same time, a DateTimeZone private property $tz was declared but not used.

It seems property got renamed somewhere in time in code usage, but not in property declaration.

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?

    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.
  • Are you creating a new feature?

    • Why is the new feature needed? What purpose does it serve?
    • How will users use the new feature?
    • Base your feature on the develop branch, and submit against that branch.
    • Add only one feature per pull request; split multiple features over multiple pull requests
    • Add tests for the new feature.
    • Add documentation for the new feature.
    • Add a CHANGELOG.md entry for the new feature.
  • Is this related to quality assurance?

  • Is this related to documentation?

In code constructor, $this->utc referenced a non-existing property; at the same time, a DateTimeZone private property $tz was declared but not used.

It seems property got renamed somewhere in time in code usage, but not in property declaration.
@michalbundyra
Copy link
Member

Thanks, @adrian-martinez-interactiv4!

michalbundyra added a commit that referenced this pull request Dec 31, 2019
Fix unused private $tz, add missing $utc private properties
@michalbundyra michalbundyra merged commit 499dff3 into zendframework:master Dec 31, 2019
michalbundyra added a commit that referenced this pull request Dec 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants