Fixes Issue #318 - SelectDecorator - subselect limit parameter not prefixed

[fuel-odrais]

Provide a narrative description of what you are trying to accomplish:

• Are you fixing a bug?
  • Detail how the bug is invoked currently.
    Call prepareStatementForSqlObject on a Select with a sub-Select that has limit and/or offset set
  • Detail the original, incorrect behavior.
    A PDO Exception is thrown: PDOException: SQLSTATE[HY093]: Invalid parameter number: parameter was not defined
  • Detail the new, expected behavior.
    The statement is properly generated.
  • Base your feature on the master branch, and submit against that branch.
  • Add a regression test that demonstrates the bug, and proves the fix.
  • Add a CHANGELOG.md entry for the fix.

[tptrixtop]

Looks like that was fixed by that #300

[fuel-odrais]

@tptrixtop:

In PR #300, src/Sql/Platform/Mysql/SelectDecorator.php line 54 is this:

$parameterContainer->offsetSet($paramPrefix . 'limit', $this->limit, ParameterContainer::TYPE_INTEGER);

That code associates the Select's limit property with a SQL parameter named $paramPrefix . 'limit'.

Then we return the name of the SQL parameter that will actually be returned from the generated query. That string value is missing the $paramPrefix value.

I've included unit tests to demonstrate the bug and would be happy to make a commit with the tests only so you can verify.

[tptrixtop]

@fuel-odrais

Ah, got it sir)

[tptrixtop]

Fix makes sense.

[tptrixtop]

ping @webimpress i think)

[michalbundyra]

LGTM 👍

[michalbundyra]

@tptrixtop Sorry, I am not a maintainer... Ping @ezimuel :)

[ezimuel]

@fuel-odrais Thanks!

[MatyCZ]

When will be this fix released as new zend-db version?