WIP PSR7 conformance tests #49
Conversation
Maks3w
force-pushed
the
feature/psr7-compliance-suite
branch
from
353516b
to
ffe80ef
Compare
Already tested by PSR7 test suite compliance
> You can opt-in to preserving the original state of the Host header by passing true for the second ($preserveHost) argument. When this argument is set to true, the returned request will not update the Host header of the returned message -- unless the message contains no Host header. **unless the message contains no Host header.** So $preserveHost MUST be ignored if message does not have a Host header
…ce-suite WIP PSR7 conformance tests
- If none is provided, lazy-instantiate one.
|
@Maks3w I've pushed fixes to issues to https://github.com/weierophinney/zend-diactoros/tree/hotfix/49 However, there's one test I disagree with:
which is exactly what Diactoros does. Once you fix that test, I think I can merge the changes both you and I have done. |
|
need rebase |
|
I've deleted several comments on this thread, as the behavior and communication were not civil or advancing the discussion of this pull request. |
|
This PR is not intended to be merged. This PR only presents the Prs7Assertions project for to discuss about if the implementation is or not correct. |
@Maks3w Okay. That said, please see my note above: one of the assertions is incorrect currently. Implementations are allowed to cast a reason phrase to the IANA recommended reason phrase if one exists. If you truly want to check against an empty-string reason phrase, you'll need to set the status to one that isn't currently defined by the IANA. |
|
@Maks3w Also, while you may not intend to merge it, I fixed items as a result of merging locally. As such, I'd really love to have this mergeable at some point... |
- If none is provided, lazy-instantiate one.
|
I've cherry-picked the code changes, and updated the two tests in |
|
Closing due to lack of activity. |
This is an example of integration with maks3w/psr7-assertions a PSR-7 conformance test library
This library aims to provide a common set of tests for every PSR-7 implementation