test improvements #50
Conversation
This test method asserts trait customer constructor which is totally unrelated with the purpose of the whole test case
This test method asserts trait customer constructor which is totally unrelated with the purpose of the whole test case
| $headers = ['X-Foo' => ['bar']]; | ||
| $this->message = new Request(null, null, $this->stream, $headers); | ||
| $this->assertSame($headers, $this->message->getHeaders()); | ||
| } |
There was a problem hiding this comment.
Why did you remove this test?
- Reinstated the two tests that were removed. - Updated property docblocks to be full length vs single-line, per our CS.
|
I re-instated the two tests that were removed when merging. |
|
@weierophinney Those tests was not testing the trait. Those tests was testing Request constructor It's totally out of the scope |
|
Then moving them to the correct test suite would have worked, but not
|
|
@weierophinney Please I can't fix all the test suite at once. I need to go by steps |
No description provided.