File validation fails when file contains sub-arrays

[jonhudson]

This patch updates the ServerRequestFactory to properly marshal uploaded files that are represented as a nested associative array (i.e., sub-arrays with non-numeric keys). As an example, prior to this patch, the following uploaded file structure would fail:

[
    'files' => [
        'tmp_name' => [
            'first_one' => 'php://temp',
        ],
        'tmp_name' => [
            'first_one' => 0,
        ],
        'error' => [
            'first_one' => 0,
        ],
        'name' => [
            'first_one' => 'foo.bar',
        ],
        'type' => [
            'first_one' => 'text/plain',
        ],
    ],
]

This structure is now correctly parsed.

[weierophinney]

Please update the pull request summary to describe what this accomplishes; since I link to the PRs in the changelog, that's often the first place people look to understand how the change impacts them.

To be clear: we already support sub-arrays, but specifically indexed sub-arrays, vs associative sub-arrays, which is what this PR addresses.

[weierophinney]

There's no need to create a new array here.

[weierophinney]

I stand corrected when running the unit tests. Still trying to understand why this change results in any change in behavior…

[jonhudson]

The UploadedFile objects were being appended to the $files array, which meant that the tmp_name and other attributes preceeded them in the array. When same array gets passed to the validation function, it was trying to then validate strings such as the tmp_name as an instance of UploadedFile, and failing. So I just created a new array to store the UploadedFile objects in and returned that instead.

[weierophinney]

I've updated the summary for you.

[jonhudson]

Thank you.