Bugfix: ClassMethods strategies tied to original name

[BreyndotEchse]

All hydrators hydrate values by calling $this->hydrateValue($this->hydrateName($originalName, $data), $value, $data) (simplified).

Only ClassMethods calls hydrateValue with the original array key passed to hydrate: $this->hydrateValue($originalName, $value, $data) (simplified)

• First commit: Demonstration test case
• Second commit: Bugfix

[BreyndotEchse]

Waiting for opinions on #46

[froschdesign]

@BreyndotEchse
Can you provide your bugfix? Please do not change existing tests. (Example)

Thanks!

[BreyndotEchse]

Cannot help you at the moment (vacation). You might take a look on @boesing's PR BreyndotEchse#1 in the meantime.

[froschdesign]

@BreyndotEchse

at the moment (vacation)

Then I will not disturb you!

You might take a look on @boesing's PR BreyndotEchse#1…

Great. Thank you!

[boesing]

@froschdesign Within my PR, I'd to change the HydratorTestTrait provided by @BreyndotEchse but the other UnitTests still passed.
Dunno why travis actually arguing about javascript.

[boesing]

The PHPUnit dependency should be raised to at least v5.2 even if this does not affect the problem.
Obviously zendframework/zend-servicemanager#07d53d35fdeb89ade8d6f72fe5ca2497f89b57f1 dropped PHPUnit 4 support.

[BreyndotEchse]

@boesing there is already a PR: #55

[boesing]

Yah, until then, the unit tests may fail. I dont expect this to get merged with failed unit tests.
Just wanted to say.

[kokspflanze]

these fails are no problem of that PR,

if #55 get merged before that PR, we have to change that PR, or otherwise change #55

i dont see a problem with that.

[boesing]

I dont have any problems with that either. Just wanted to say that former PR got declined because tests failed which didn't caused by the changes of those PR.
Just my 2 cents.

[weierophinney]

Thanks, @BreyndotEchse

[BreyndotEchse]

Thanks, @boesing :)