Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Fix Kosovo PhoneNumber regexp #119

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Fix Kosovo PhoneNumber regexp #119

merged 2 commits into from
Sep 25, 2019

Conversation

michalbundyra
Copy link
Member

@michalbundyra michalbundyra commented Sep 25, 2019 •
edited
Loading

Added tests and updated regexps

See: https://en.wikipedia.org/wiki/Telephone_numbers_in_Kosovo

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

@michalbundyra michalbundyra added this to the 2.9.1 milestone Sep 25, 2019
michalbundyra added a commit that referenced this pull request Sep 25, 2019
@michalbundyra
Merge pull request #119 from webimpress/hotfix/kosovo-phone-numbers
23d1dae 
Fix Kosovo PhoneNumber regexp
michalbundyra added a commit that referenced this pull request Sep 25, 2019
@michalbundyra
Merge branch 'hotfix/119' into develop
60362b7 
Forward port #119
@michalbundyra michalbundyra merged commit 1c3f415 into zendframework:master Sep 25, 2019
@michalbundyra michalbundyra deleted the hotfix/kosovo-phone-numbers branch September 25, 2019 19:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@froschdesign froschdesign Awaiting requested review from froschdesign

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.
1 participant
@michalbundyra