This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Multiple isValid calls #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are with errors in PHPUnit |
weierophinney
added a commit
that referenced
this pull request
Feb 10, 2016
The test as written did not work on my environment, and any attempt I made to seed it with what should be a known-good value and set of options failed. In the end, I used `IntlDateFormatter::create(/* ... */)->format(new DateTime())`, per the basic validation tests, and this allowed it to work.
weierophinney
added a commit
that referenced
this pull request
Feb 10, 2016
weierophinney
added a commit
that referenced
this pull request
Feb 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we call validator with a forced parse error, next time we try to validate, we'll always receive
false. I just fixed it, cleaning the$this->formatterand reconfiguring it directly with configured object parameters.Please check
ZendTest\Validator\DateTimeTest::testMultipleIsValidCallstest.