Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

use sm3 configure when possible #47

Merged
merged 3 commits into from
Jun 7, 2016

Conversation

pine3ree
Copy link
Contributor

to prevent any performance overhead.

(same reasons for zendframework/zend-form#77)

$serviceManager->setAlias($alias, $target);
if (method_exists($serviceManager, 'configure')) {
$serviceManager->configure($this->toArray());
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early return

@samsonasik
Copy link
Contributor

@Ocramius @pine3ree updated the code as you suggested

@weierophinney weierophinney modified the milestones: 2.7.3, 2.8.0 Jun 7, 2016
@weierophinney weierophinney self-assigned this Jun 7, 2016
@weierophinney weierophinney merged commit 6909d27 into zendframework:master Jun 7, 2016
weierophinney added a commit that referenced this pull request Jun 7, 2016
use sm3 configure when possible
weierophinney added a commit that referenced this pull request Jun 7, 2016
weierophinney added a commit that referenced this pull request Jun 7, 2016
weierophinney added a commit that referenced this pull request Jun 7, 2016
@weierophinney
Copy link
Member

Thanks, @pine3ree

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants