You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing the Content-Type header there is an assumption that the type and key/value pairs can be split by semi-colon, but this is incorrect when a value contains a semi-colon (eg. name="foo; bar"). This format is covered by the RFC (https://tools.ietf.org/html/rfc2045#page-12, Must be in quoted-string to use within parameter values), and is seen in data in the wild. This patch adds support for this.
Currently an exception is thrown in strict mode because of an undefined offset (Undefined offset: 1). I've updated the code to use parse_str to better handle this data, which I think is an improvement over the regexp splitting, but still not ideal without a proper lexer/tokenizer obv.
I've also enabled strict mode for PHPUnit by default to expose these kinds of bugs in the test suite.
@weierophinney Thanks - the parser class works for this case if you can allow a minor customisation (though the name is now perhaps a little misleading if it's used in both locations).
Since the AddressListParser has not yet been released, I've taken the liberty of renaming it to ListParser, and pushing the changes back to your branch. With those in place, I think this is ready to go.
The reason will be displayed to describe this comment to others. Learn more.
it now correctly ignores them.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing the
Content-Typeheader there is an assumption that the type and key/value pairs can be split by semi-colon, but this is incorrect when a value contains a semi-colon (eg.name="foo; bar"). This format is covered by the RFC (https://tools.ietf.org/html/rfc2045#page-12,Must be in quoted-string to use within parameter values), and is seen in data in the wild. This patch adds support for this.Currently an exception is thrown in strict mode because of an undefined offset (
Undefined offset: 1). I've updated the code to useparse_strto better handle this data, which I think is an improvement over the regexp splitting, but still not ideal without a proper lexer/tokenizer obv.I've also enabled strict mode for PHPUnit by default to expose these kinds of bugs in the test suite.