This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Use RFC compliant EOL to allow new lines in message body #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -688,7 +688,7 @@ public function testRestoreFromSerializedString() | |||
| $this->message->addFrom('matthew@example.com', "Matthew Weier O'Phinney"); | |||
| $this->message->addCc('zf-contributors@example.com', 'ZF Contributors List'); | |||
| $this->message->setSubject('This is a subject'); | |||
| $this->message->setBody('foo'); | |||
| $this->message->setBody("foo\n\ntest"); | |||
There was a problem hiding this comment.
Changing existing tests can lead to cases where we change existing behavior. As such, I'm going to separate this into its own test when I merge, to verify (a) the old behavior, and (b) the fix this patch presents.
weierophinney
added a commit
that referenced
this pull request
Apr 11, 2016
Use RFC compliant EOL to allow new lines in message body
weierophinney
added a commit
that referenced
this pull request
Apr 11, 2016
- and restored behavior of previous test.
weierophinney
added a commit
that referenced
this pull request
Apr 11, 2016
weierophinney
added a commit
that referenced
this pull request
Apr 11, 2016
glensc
pushed a commit
to eventum/zend-mail
that referenced
this pull request
Jan 18, 2017
- and restored behavior of previous test.
glensc
added a commit
to eventum/zend-mail
that referenced
this pull request
Jan 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.ietf.org/rfc/rfc2821.txt