This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Remove deprecated functionality #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bumps zend-servicemanager to only v3 versions. - Removes ServiceLocatorAware initializers from both ServiceManagerConfig and ControllerManager
Deprecated some time ago in favor of the ControllerManager service.
- Removed items that are now requirements - Removed zend-di (as zend-servicemanager-di will bring it in, and it's already a suggestion) - Removed zend-config (as there's no relevance; the config service can be an array or a Config instance, but there's no preference for either)
Require v3 releases of core functionality: - zend-eventmanager - zend-servicemanager - zend-stdlib
`ServiceLocatorAwareInterface` was duck-typed in `AbstractController` previously; this commit removes that implementation.
weierophinney
added a commit
that referenced
this pull request
Apr 12, 2016
weierophinney
added a commit
that referenced
this pull request
Apr 12, 2016
This was referenced Apr 12, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes functionality previously marked or messaged as deprecated, including:
ControllerLoaderfactory and service (the latter of which was aliased toControllerManageranyways)Zend\Mvc\View\SendResponseListener(deprecated, and merely extendedZend\Mvc\SendResponseListener)Application::send()(deprecated, and a no-op)DispatchListener::marshallControllerNotFoundEvent()(deprecated, and proxied tomarshalControllerNotFoundEvent())ServiceLocatorAwareinitializers from bothServiceManagerConfigandControllerManager.The patch also bumps the requirements for the following components to their v3 releases:
ServiceLocatorAwareinitializers)and bumps the minimum supported PHP version to 5.6.
Finally the patch also cleans up the composer suggestions list to remove items that are now required by default, and remove items that are no longer relevant.