This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
marshalBadControllerEvent argument type hinting #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exception -> Throwable At line 102 marshalBadControllerEvent used with Throwable argument type
| @@ -216,7 +216,7 @@ protected function marshalBadControllerEvent( | |||
| $controllerName, | |||
| MvcEvent $event, | |||
| Application $application, | |||
| \Exception $exception | |||
| \Throwable $exception | |||
There was a problem hiding this comment.
it is not gonna work on php 5.6 :(
please have a look in composer.json, and it still must work on: "php": "^5.6 || ^7.0"
There was a problem hiding this comment.
@webimpress It works fine on PHP 5.6; the class does not need to exist for a typehint check.
There was a problem hiding this comment.
Missed that this was in the method signature and not the docblock. I'll remove the typehint during merge.
|
it was already resolved in release 2.7.9: should be also ported to release v3 /cc @weierophinney |
Closed
|
Thanks @autowp ! |
weierophinney
added a commit
that referenced
this pull request
Jun 30, 2016
marshalBadControllerEvent argument type hinting
weierophinney
added a commit
that referenced
this pull request
Jun 30, 2016
weierophinney
added a commit
that referenced
this pull request
Jun 30, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception -> Throwable
At line 102 marshalBadControllerEvent used with Throwable argument type