This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Pipe should not decorate MiddlewarePipe instances #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In prepping Expressive to use Stratigility 2, I discovered that `MiddlewarePipe` instances piped into another `MiddlewarePipe` instance were being decorated as callable middleware; this should no longer happen. This patch adds a test to ensure it does not happen, and updates `pipe()` to not decorate callable `ServerMiddlewareInterface` instances. In doing so, the `isInteropMiddleware()` method is no longer relevant, and I removed it; since it was marked `private`, this is a backwards compatible change.
weierophinney
added a commit
that referenced
this pull request
Jan 25, 2017
weierophinney
added a commit
that referenced
this pull request
Jan 25, 2017
weierophinney
added a commit
that referenced
this pull request
Jan 25, 2017
Forward port #98 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prepping Expressive to use Stratigility 2, I discovered that
MiddlewarePipeinstances piped into anotherMiddlewarePipeinstance were being decorated as callable middleware; this should no longer happen.This patch adds a test to ensure it does not happen, and updates
pipe()to not decorate callableServerMiddlewareInterfaceinstances.In doing so, the
isInteropMiddleware()method is no longer relevant, and I removed it; since it was markedprivate, this is a backwards compatible change.