PHP7 is more strict with custom session handlers, DbTable.php does not correctly return true #654
Conversation
… return true even though the session was updated
|
More information: it was triggering this error " Warning: session_write_close(): Failed to write session data (user). Please verify that the current setting of session.save_path is correct (/tmp)" until the write method was adjusted to return true. |
|
Sorry, but I can not found a signed CLA. |
| } | ||
| } catch (Exception $e) { | ||
| throw new Zend_Session_SaveHandler_Exception( |
There was a problem hiding this comment.
It is prefferable to include previous exception as well.
|
@froschdesign can we do something about this? |
|
As I mentioned in #665, I think the best choice here is to simply fix the return value and always return true in The rest of this PR that catches the exceptions and re-throws with a Session component exception might be nice, but it's really addressing something unrelated. I think it's best to just make the minimal necessary change. |
|
What is going on with this bug? Is there a fix for this issue in an official release? Thanks. |
|
As @froschdesign would say:
The simplest workaround is to write your own class that extends from the DbTable handler, and override the |
|
OK, fair enough. |
It should always return true unless there is an actual error.