Skip to content
This repository has been archived by the owner on May 16, 2018. It is now read-only.

Fix for 655 issue #670

Merged
merged 1 commit into from
Feb 15, 2016
Merged

Fix for 655 issue #670

merged 1 commit into from
Feb 15, 2016

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Feb 8, 2016

This PR fixes the #655 issue for MySQL. I removed the filter of null-bytes from quote() in Pdo\Abstract and I moved in MsSQL and Sqlite for ZF2015-08. This should remove the double quotes of null-bytes for MySQL. I provided this test for MySQL.
Waiting feedback from @Thomas-Gelf, @moshevds and others.

@moshevds
Copy link

I installed this fix on one of our servers and it seems to work. I only tested the MySQL changes because that's what we use. It was excepted to work as this effectively reverts the change that broke things. Thanks for the fix.

@Thomas-Gelf
Copy link

Same here, thanks @ezimuel! Been pretty busy at a customer this week, sorry for the late reply. As @moshevds already mentioned, the erroneous line has been removed so nothing else was to expect. Also good to see a test checking the expected outcome again. Honestly, I didn't run it - but it looks good to me. No MSSQL available right now, couldn't test it there. I could give PostreSQL a try if you want, but I have no doubt that also there the problem should be fixed.

Cheers,
Thomas

@ezimuel ezimuel added this to the 1.12.18 milestone Feb 15, 2016
@ezimuel
Copy link
Contributor Author

ezimuel commented Feb 15, 2016

@Thomas-Gelf and @moshevds I tested also again SQLite and MSSQL to be sure that the previous patch ZF2015-08 works as expected. Everything seems to be ok so we can schedule a release this week, thanks!
/cc @weierophinney

froschdesign added a commit that referenced this pull request Feb 15, 2016
Fix for 655 issue - ZF2015-08 breaks binary data
@froschdesign froschdesign merged commit ebf608f into zendframework:master Feb 15, 2016
@froschdesign
Copy link
Member

@ezimuel
Thanks! 👍

tavy315 added a commit to tavy315/zendframework1 that referenced this pull request Apr 14, 2016
Fix for 655 issue - ZF2015-08 breaks binary data
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants