fix deprecated impls, closes #72 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very helpful, thank you! Would you be willing to resubmit this without the version bump? |
|
There you go @zenhob thanks! |
zenhob
reviewed
Feb 9, 2017
lib/hcl/version.rb
Outdated
| @@ -1,3 +1,3 @@ | |||
| module HCl | |||
| VERSION = '0.4.15' | |||
There was a problem hiding this comment.
I'd prefer the version bump to be in a separate commit, could you remove this change from the patch?
zenhob
reviewed
Feb 9, 2017
Gemfile.lock
Outdated
| @@ -1,7 +1,7 @@ | |||
| PATH | |||
| remote: . | |||
| specs: | |||
| hcl (0.4.15) | |||
| hcl (0.4.16) | |||
There was a problem hiding this comment.
We should keep the exiting version for this too.
|
Sorry, I meant the hcl version bumps in the Again, thank you so much! |
|
@zenhob thanks for the guidance here. I think this last push is the right stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #72
Thanks for hcl!