Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App#save_password: Shell escape password #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jan 28, 2018

  1. App#save_password: Shell escape password

    Escape special shell characters so that passwords with single quotes can
    be saved to the keychain. Otherwise, the single quotes surrounding the
    "-w '%s'" cause an error on passwords with single quotes.
    
    I know testing private methods is not recommended, but this seemed like
    something that would be good to test. Maybe the method should be made
    public if that's a concern?
    teddywing committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    c70cf39 View commit details
    Browse the repository at this point in the history