Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persian language #64

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Conversation

aliruss
Copy link
Contributor

@aliruss aliruss commented Oct 11, 2019

No description provided.

@niushapaks niushapaks self-assigned this Oct 11, 2019
@kefranabg
Copy link
Collaborator

kefranabg commented Oct 12, 2019

Thanks for this @aliruss. @niusha-paks will do a review ASAP

@aliruss
Copy link
Contributor Author

aliruss commented Oct 13, 2019

hi @kefranabg and you'r welcome

Copy link

@niushapaks niushapaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Ali,

Many thanks for your contribution !

I have submitted 8 changes request, but you have done an awesome work !

Feel free to respond to my requests if it is unclear.

Best Regards,

Niusha

> Dieses Cheat Sheet fasst wichtige Schritte zusammen, die dir dabei helfen sollen, dein Open Source Projekt zu bewerben. Klicke auf einen Punkt, um mehr über das Thema zu erfahren.

Verfügbare Sprachen:

- [English](./README.md)
- [Français](./README-fr.md)
- [Deutsch](./README-de.md)
- [پارسی](./README-fa.md)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use native "فارسی" language name instead of "پارسی" variant


List of available languages:

- [English](./README.md)
- [Français](./README-fr.md)
- [Deutsch](./README-de.md)
- [پارسی](./README-fa.md)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use native "فارسی" language name instead of "پارسی" variant

@@ -17,6 +17,7 @@ Langages disponibles :
- [English](./README.md)
- [Français](./README-fr.md)
- [Deutsch](./README-de.md)
- [پارسی](./README-fa.md)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use native "فارسی" language name instead of "پارسی" variant

<summary>↗️ پروژه خود را در شبکه های اجتماعی و پلتفرم های اختصاصی به اشتراک بگزارید</summary>
<p dir="rtl" align="right">

> درباره کار فوق العاده خود در شبکه های اجتماعی و پلتفرم های اختصاصی مثل ابزار های زیر بگویید:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use "شبکه های مهم شناخته شده زیر بگویید" instead of "ابزار های زیر بگویید"

<summary>📘 فایل مستندات پروژه را تهیه کنید </summary>
<p>

> ساخت مستندات جزو مهمترین مراحل است. اگر شما یک مستند کوتاه برای پروژه خود دارید میتوانید آن را همراه با فایل README در معرض نمایش عموم قرار دهید. مستنداتی همون[vuepress](https://v1.vuepress.vuejs.org) میتوانند به شما کمک کنند تا مستندات پروژه خود را بسیار روان و زیبا بنویسید.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check sentences continuation order because it is not clear

</details>

<details>
<summary>📃 مقالاتی بنویسید که در آن به پروژه شما اشاره میکند</summary>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use "اشاره میشود" or "اشاره میکنند " instead of "اشاره میکند"

</details>

<details>
<summary>🎤 پروژه خود را در کنفرانش ها معرفی کنید</summary>
Copy link

@niushapaks niushapaks Oct 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please correct کنفرانس word (typo error : "کنفرانش")

<summary>🕐 بهترین زمان را برای انتشار برنامه در شبکه های اجتماعی در نظر بگیرید</summary>
<p>

> برنامه را در تعطیلات و آخر هفته ها منتشر نکنید این کار باعث کمتر دیده شدن شما میشود آن معمولا این کار را در وسط هفته انجام دهید.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please wipe out "آن " word by splitting into two phrases

@kefranabg
Copy link
Collaborator

Hi @aliruss, are you ok to consider @niusha-paks review ? 😃

Copy link

@niushapaks niushapaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments are not blocking, we can merge and correct them in a new PR.

@kefranabg kefranabg merged commit 6ff4b54 into zenika-open-source:master Dec 3, 2019
@kefranabg
Copy link
Collaborator

@all-contributors please add @niusha-paks for review

@allcontributors
Copy link
Contributor

@kefranabg

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected string in JSON at position 141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants