Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set expiration to 90 days #23

Merged
merged 1 commit into from
Dec 15, 2015
Merged

Set expiration to 90 days #23

merged 1 commit into from
Dec 15, 2015

Conversation

barryvdh
Copy link
Contributor

Expiration is 90 days currently; https://letsencrypt.org/2015/11/09/why-90-days.html

Renewal is advised every 60 days, but the information should be correct. If we want to renew early (50 or 60 days), that should be handled at the cron level (imho).

Isn't it possible to actually get the real expiration date? In case it changes?

@barryvdh
Copy link
Contributor Author

Something like this in Domain.php?

    public function getCertificateExpirationTime() {
        $certInfo = openssl_x509_parse($this->getCertificate());
        return $certInfo['validTo_time_t'];
    }

@Wouter0100
Copy link
Collaborator

Hmm, that would work too. I'm currently thinking of implementing a certificate class. This because, normally, a certificate can has multiple domains. Currently this is handled kinda wrong, using subdomains. I'll merge this, but we could implement the above given method for getting expiration time.

Thx!

Wouter0100 pushed a commit that referenced this pull request Dec 15, 2015
Set expiration to 90 days
@Wouter0100 Wouter0100 merged commit 929c19c into zenire:master Dec 15, 2015
@Wouter0100 Wouter0100 self-assigned this Dec 15, 2015
@Wouter0100 Wouter0100 added this to the 1.0 milestone Dec 15, 2015
@Wouter0100 Wouter0100 added the bug label Dec 15, 2015
@barryvdh barryvdh deleted the patch-4 branch December 15, 2015 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants