Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Duplicate Step Error #1527

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

fa9r
Copy link
Contributor

@fa9r fa9r commented May 9, 2023

Describe changes

This PR should fix error messages of the following form: zenml.exceptions.EntityExistsError: Unable to create step '...': A step with this name already exists in the pipeline run with ID '...'.

This would previously be raised if the step run preparation failed after it was already written to DB, causing the error handling code to run into this error when trying to write the failed step run later.

Note that this does not fix the underlying issues that caused the respective errors to be raised, it only fixes the error handling code such that the "correct" error message is now visible in the stack trace.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels May 9, 2023
@fa9r fa9r merged commit 713b126 into develop May 9, 2023
@fa9r fa9r deleted the bugfix/fix-duplicate-step-error-message branch May 9, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants