Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Neptune README #1554

Merged
merged 1 commit into from
May 23, 2023
Merged

Update Neptune README #1554

merged 1 commit into from
May 23, 2023

Conversation

strickvl
Copy link
Contributor

Account for Mac pip install which needs quotes around the package name.

Describe changes

I implemented/fixed _ to achieve _.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@strickvl
Update README.md
635ccfc 
Account for Mac pip install which needs quotes around the package name.
@strickvl strickvl added the documentation Improvements or additions to documentation label May 23, 2023
@strickvl strickvl requested a review from safoinme May 23, 2023 14:15
@github-actions github-actions bot added the internal To filter out internal PRs and issues label May 23, 2023
@strickvl strickvl changed the title Update Neptune docs Update Neptune README May 23, 2023
safoinme
safoinme approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@safoinme safoinme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strickvl strickvl merged commit e055d31 into develop May 23, 2023
@strickvl strickvl deleted the strickvl-patch-1 branch May 23, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@safoinme safoinme safoinme approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strickvl @safoinme