Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3.10 PyYAML Installation Issues #1695

Merged
merged 7 commits into from
Jul 19, 2023

Conversation

fa9r
Copy link
Contributor

@fa9r fa9r commented Jul 17, 2023

Background

Describe changes

  • Bumped pyyaml to >=6.0.1
  • Bumped evidently version to [0.2.7-0.2.8] which are the only versions that support both the old Evidently API which our integration code is using as well as PyYAML 6.
  • Pinned kfp to 1.8.22 which is the only 1.x version that supports PyYAML 6.
  • Pinned kfk-tekton to 1.7.1 which is the only version compatible with kfp==1.8.22
  • Removed docker-compose as dev dependency since all available versions require PyYAML 5. As a workaround, I adjusted the corresponding CI action to lazy-install the package instead.
  • Removed Python 3.7 CI checks since the new Tekton version is no longer compatible with Python 3.7 -> let's also merge Remove Python 3.7 Support #1652 before the next release

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Jul 17, 2023
@fa9r fa9r force-pushed the bugfix/fix-pyyaml-python310-install branch from f152c8b to 61f55da Compare July 17, 2023 21:15
@fa9r fa9r requested review from stefannica and schustmi July 17, 2023 21:16
@fa9r fa9r closed this Jul 17, 2023
@@ -160,8 +160,6 @@ types-setuptools = { version = "^57.4.2", optional = true }
types-six = { version = "^1.16.2", optional = true }
types-termcolor = { version = "^1.1.2", optional = true }
types-psutil = { version = "^5.8.13", optional = true }
# test framework dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this will break the CI

Copy link
Contributor Author

@fa9r fa9r Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted the integration test GH action to lazily install docker-compose in non-default environments now. I think that should work since the CI only runs non-default environment tests under Python 3.8 where PyYAML 5 shouldn't be broken in the first place.

@fa9r fa9r reopened this Jul 19, 2023
@fa9r fa9r changed the title Fix Python 3.10 Install Fix Python 3.10 PyYAML Installation Issues Jul 19, 2023
@fa9r fa9r requested a review from stefannica July 19, 2023 13:33
@fa9r fa9r mentioned this pull request Jul 19, 2023
8 tasks
Copy link
Contributor

@stefannica stefannica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work figuring out all those PyYAML version dependencies !

@fa9r fa9r merged commit 8a3ecf7 into develop Jul 19, 2023
@fa9r fa9r deleted the bugfix/fix-pyyaml-python310-install branch July 19, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants