-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python 3.10 PyYAML Installation Issues #1695
Conversation
f152c8b
to
61f55da
Compare
@@ -160,8 +160,6 @@ types-setuptools = { version = "^57.4.2", optional = true } | |||
types-six = { version = "^1.16.2", optional = true } | |||
types-termcolor = { version = "^1.1.2", optional = true } | |||
types-psutil = { version = "^5.8.13", optional = true } | |||
# test framework dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this will break the CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted the integration test GH action to lazily install docker-compose
in non-default environments now. I think that should work since the CI only runs non-default environment tests under Python 3.8 where PyYAML 5 shouldn't be broken in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work figuring out all those PyYAML version dependencies !
Background
5.4
: Pin Cython build constraint to < 3.0 yaml/pyyaml#726Describe changes
pyyaml
to>=6.0.1
evidently
version to[0.2.7-0.2.8]
which are the only versions that support both the old Evidently API which our integration code is using as well as PyYAML 6.kfp
to1.8.22
which is the only1.x
version that supports PyYAML 6.kfk-tekton
to1.7.1
which is the only version compatible withkfp==1.8.22
docker-compose
as dev dependency since all available versions require PyYAML 5. As a workaround, I adjusted the corresponding CI action to lazy-install the package instead.Pre-requisites
Please ensure you have done the following:
Types of changes