Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set the active workspace to be the default workspace server side #1989

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

stefannica
Copy link
Contributor

@stefannica stefannica commented Oct 25, 2023

Describe changes

Always set the active workspace to be the default workspace server side. This is still called by the visualization and logging features running on the server.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Oct 25, 2023
Copy link
Contributor

@AlexejPenner AlexejPenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to test this somehow before making a release with this?

@stefannica
Copy link
Contributor Author

Do we want to test this somehow before making a release with this?

Absolutely YES.

@stefannica
Copy link
Contributor Author

Do we want to test this somehow before making a release with this?

Absolutely YES.

Tested both logs and visualizations and it works.

@stefannica stefannica merged commit 7c45c9a into develop Oct 26, 2023
32 of 36 checks passed
@stefannica stefannica deleted the bug/fix-server-active-workspace branch October 26, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants