Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace parse_obj #2623

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Replace parse_obj #2623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61d5bfe
Replace parse_obj
AlexejPenner Apr 22, 2024
09dccb9
use hydrated artifact version
avishniakov Apr 22, 2024
9b903af
update test signature
avishniakov Apr 22, 2024
7e5dbf5
not link artifact to the step in save of test
avishniakov Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/zenml/orchestrators/step_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,9 @@ def _load_input_artifact(
"""
# Skip materialization for `UnmaterializedArtifact`.
if data_type == UnmaterializedArtifact:
return UnmaterializedArtifact.parse_obj(artifact)
return UnmaterializedArtifact(
**artifact.get_hydrated_version().dict()
)

if data_type is Any or is_union(get_origin(data_type)):
# Entrypoint function does not define a specific type for the input,
Expand Down
11 changes: 6 additions & 5 deletions tests/unit/orchestrators/test_step_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import pytest

from zenml import save_artifact
from zenml.artifacts.unmaterialized_artifact import UnmaterializedArtifact
from zenml.config.pipeline_configurations import PipelineConfiguration
from zenml.config.step_configurations import Step
Expand Down Expand Up @@ -147,11 +148,13 @@ def test_running_a_failing_step(
mock_publish_successful_step_run.assert_not_called()


def test_loading_unmaterialized_input_artifact(
local_stack, sample_artifact_version_model
):
def test_loading_unmaterialized_input_artifact(local_stack, clean_client):
"""Tests that having an input of type `UnmaterializedArtifact` does not
materialize the artifact but instead returns the response model."""
artifact_response = save_artifact(
42, "main_answer", manual_save=False
).get_hydrated_version()

step = Step.parse_obj(
{
"spec": {
Expand All @@ -164,8 +167,6 @@ def test_loading_unmaterialized_input_artifact(
}
)
runner = StepRunner(step=step, stack=local_stack)
artifact_response = sample_artifact_version_model

artifact = runner._load_input_artifact(
artifact=artifact_response, data_type=UnmaterializedArtifact
)
Expand Down
Loading