Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent KFP install timeouts during stack up #299

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

stefannica
Copy link
Contributor

@stefannica stefannica commented Jan 7, 2022

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

The Kubeflow Kustomize repository is quite large, as it consists of
several components. As a consequence, kubectl apply -f can sometimes
fail with a timeout while it's git-cloning the files locally. To prevent
that, a custom timeout value of 1 minute is used instead of the
kustomize default value of 27 seconds.

[1] kustomize option to allow configurable git timeouts: kubernetes-sigs/kustomize#3900

The Kubeflow Kustomize repository is quite large, as it consists of
several components. As a consequence, `kubectl apply -f` can sometimes
fail with a timeout while it's git-cloning the files locally. To prevent
that, a custom timeout value of 1 minute is used instead of the
kustomize default value of 27 seconds.

Signed-off-by: Stefan Nica <stefan@zenml.io>
@stefannica stefannica added the internal To filter out internal PRs and issues label Jan 7, 2022
Copy link
Contributor

@schustmi schustmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do you think 1 minute is enough or should we increase it even further?

@stefannica
Copy link
Contributor Author

Nice! Do you think 1 minute is enough or should we increase it even further?

The default 27 seconds were almost enough to allow me to install kubeflow manually after a couple of retries. I think 1 minute is enough, yes. In any case, we can bump it again if we run into problems later.

Copy link
Contributor

@alex-zenml alex-zenml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😀

@stefannica stefannica merged commit 0d74b2d into main Jan 7, 2022
@stefannica stefannica deleted the stefan/fix-kfp-up-timeouts branch January 7, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants