Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken feature store example #602

Merged
merged 2 commits into from
May 17, 2022
Merged

Conversation

strickvl
Copy link
Contributor

Our feast example has been broken since day one, because our .gitignore didn't allow yaml files to be committed. This means that a core configuration file was missing.

I've unblocked the YAML dam and added the config file back in.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@strickvl strickvl added bug Something isn't working internal To filter out internal PRs and issues labels May 17, 2022
@strickvl strickvl requested a review from htahir1 May 17, 2022 16:05
@strickvl strickvl merged commit 12cbead into develop May 17, 2022
@strickvl strickvl deleted the bugfix/ENG-888-feast-example-yaml branch May 17, 2022 17:17
strickvl added a commit that referenced this pull request May 18, 2022
* Fix broken feature store example (#602)

* allow yaml files

* include yaml config

* Added success message (#603)

* Added success message

* Reformatted

* remove extra colon

* add extra spacing

* update zenml go behaviour

Co-authored-by: Alexej Penner <thealexejpenner@gmail.com>
htahir1 added a commit that referenced this pull request May 18, 2022
* Getting there

* midway best practices

* Added more explain stuff

* Edited best practices

* checkpoint

* Checkpoint for quickstart

* Added notebook

* Added dash visualizer jupyter

* Refactored imports

* Added runner script

* Quickstart now follows best practices

* Quickstart formatted

* Updated zenml go

* Latest quickstart

* Adapted zenml go to new quickstart

* Added event for extending ZenML

* Linting fixes

* zenml go is now optout too

* Made an exception for pipeline yamls

* Added config

* Apply suggestions from code review

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Deleting

* preserving user metadata

* Fromatted latest

* Formatting and linting

* Formatting and linting

* Typo

* One function down

* Update stakc comp done

* Deregister stack

* Create user

* Delete user

* Get user

* Added all events

* Added project

* Added facade for all base methods

* Deleted flavor event delted

* Wrapped track event to make sure deduplication doesnt happen

* Wrapped track event to make sure deduplication doesnt happen

* Registered stack refactored

* Flavor event is now properly done

* Update stack done

* Added import and export stack

* Added import and export stack

* Analytics events done

* Copy paste error

* Fixed mypy errors

* Toc updated

* Restructurung

* Restructure

* GitBook: [#2] No subject

* Fix/update `zenml go` (#606)

* Fix broken feature store example (#602)

* allow yaml files

* include yaml config

* Added success message (#603)

* Added success message

* Reformatted

* remove extra colon

* add extra spacing

* update zenml go behaviour

Co-authored-by: Alexej Penner <thealexejpenner@gmail.com>

* Analytics turned off in copy_active_configuration

* Docstring nits

* Formatting

* Added todo

* Revamp Quickstart (#604)

* WIP: rework/reformat quickstart.

* Finished quickstart.ipynb (untested).

* Improved docs/comments of quickstart.ipynb.

* Fix bugs in quickstart.ipynb. Everything except dash integration works.

* Update quickstart README and setup.py.

* Bug fix: allow Facets visualizer magic in Colab.

* Added screenshots for all visualizations to quickstart.ipynb.

* Added pipeline visualization to quickstart.ipynb.

* Added stack visualization to quickstart.ipynb.

* Wrote new quickstart run.py script / code modules.

* Fix grammar / spelling of quickstart.

* Update quickstart README: declare notebook execution as recommended and move run.py-specific set up instructions out of prerequisites.

* Adjust quickstart to reviewer feedback.

* Added magic flag

Co-authored-by: Hamza Tahir <htahir111@gmail.com>

* Changed best practices to misc and added resources section

* Finished landing page of resoruces

* Half finished best practices

* Added eventbrite

* Getting there

* FAQs added basically

* Fixed link;

* GitBook: [#3] No subject

* Apply suggestions from code review

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Co-authored-by: Alexej Penner <thealexejpenner@gmail.com>
Co-authored-by: Felix Altenberger <felix@zenml.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants