This repository has been archived by the owner on Oct 5, 2023. It is now read-only.
feat: report edit page design #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: remove edit route and redo report class * refactor: rename report components * refactor: rename report type and update reference * refactor: combine marks section * refactor: report class redesign and encoding component wrapping * refactor: modify slice chart to use new report class settings * feat: update table design * feat: add option filtering logic * feat: add table x-y axis direction * feat: update line chart and adjust theme to purple * feat: finish beeswarm update * bug: fix svelecte label not defined error and redo model search * bug: fix empty model table error * refactor: add styling for svelecte
cabreraalex
added a commit
that referenced
this pull request
May 5, 2023
* refactor: round corner reports and fix header layout * fix: update report name until click outside * feat: add chart type design on /edit page * feat: add onclick for edit page chart type selection * refactor: modularize chart type into component * refactor: remove unused css selector * feat: add selected chart type default color * feat: add encoding design * fix: add margin for encoding labels * feat: add slice chips * feat: add encoding's x, y axis logics * feat: add marks section * refactor: new design for report name header * refactor: cleaning routes * merge main to fetch newest changes * feat: add slices button * refactor: report class re-design (#642) * refactor: remove edit route and redo report class * refactor: rename report components * refactor: rename report type and update reference * refactor: combine marks section * refactor: report class redesign and encoding component wrapping * refactor: modify slice chart to use new report class settings * feat: update table design * feat: add option filtering logic * feat: add table x-y axis direction * feat: update line chart and adjust theme to purple * feat: finish beeswarm update * bug: fix svelecte label not defined error and redo model search * bug: fix empty model table error * refactor: add styling for svelecte * refactor: change slice into svelecte style * refactor: remove report predicates and console.log * refactor: remove unused resources * minor style --------- Co-authored-by: Alex Cabrera <alex.cabrera@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.