This repository has been archived by the owner on Oct 5, 2023. It is now read-only.
fix: slice creation #750
Merged
fix: slice creation #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could ya describe what this does/fixes? |
stevenyh3
commented
May 3, 2023
| @@ -22,7 +22,7 @@ | |||
|
|
|||
| // check if predicates are valid (not empty) | |||
| function checkValidPredicates(preds) { | |||
| let valid = true; | |||
There was a problem hiding this comment.
Adding a validity check for empty predicates.
stevenyh3
commented
May 3, 2023
| @@ -135,7 +137,10 @@ | |||
| }); | |||
| return s; | |||
| }); | |||
| selections.update((sels) => ({ slices: [], metadata: sels.metadata })); | |||
There was a problem hiding this comment.
Currently after we create/update the slice, the selection will be cleared and will need to select the modified slice again to see the changes, so I think maybe we can auto-select the new slice to see immediate changes.
stevenyh3
commented
May 3, 2023
| $selections.slices.forEach((s, i) => { | ||
| let sli_preds = $slices.get(s).filterPredicates; | ||
| if (i !== 0) { | ||
| sli_preds.join = "&"; | ||
| } | ||
| slicesPredicates.predicates.push(sli_preds); |
There was a problem hiding this comment.
The type should be predicate instead of predicate group when creating a derived(nested) slice from the current selected slice.
cabreraalex
pushed a commit
that referenced
this pull request
May 5, 2023
* fix: assign value field for column * feat: add predicate check before create slice * fix: avoid showing multiple mdiDotsHorizontal * feat: support nested slices creation * fix: show option menu * fix: handle empty predicates & deep copy nested slices * refactor: auto-select slice after create/update to see immediate changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.