Evaluation of unseen user and Incremental modeling issues in BPRMF #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user is empty fixed: random instance need to be initialized to perform incremental modeling(AddFeedback) in BPRMF
… no samples in training data
To perform incremental modeling on the loaded model(LoadModel), random instance need to be instantiated on LoadModel().
|
Another one, Incremental modeling cannot be performed after LoadModel() with Feedback data because random instance of BPRMF class is instantiated on Train(). I think random instance need to be instantiated on LoadModel() too. commit: a056d45 |
zenogantner
added a commit
that referenced
this pull request
Jul 21, 2013
Evaluation of unseen user and Incremental modeling issues in BPRMF
|
Thank you for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, here is trivial one 79686af
Passing null parameter to HashSet when training_user_matrix[user_id] == null
===> ERROR: Argument cannot be null.
Parameter name: collection at System.Collections.Generic.HashSet1[System.Int32]..ctor (IEnumerable1 collection, IEqualityComparer1 comparer) [0x0006d] in /data1/daum/kskim/program/mono-2.10.8/mcs/class/System.Core/System.Collections.Generic/HashSet.cs:123
at System.Collections.Generic.HashSet1[System.Int32]..ctor (IEnumerable`1 collection) [0x00000] in :0
at MyMediaLite.Eval.Items+c__AnonStoreyA.<>m__14 (Int32 user_id) [0x0002e] in /data1/daum/kskim/mymedialite.git/src/MyMediaLite/Eval/Items.cs:146