Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples are broken #255

Open
rybarczykj opened this issue Jan 28, 2024 · 2 comments
Open

Examples are broken #255

rybarczykj opened this issue Jan 28, 2024 · 2 comments

Comments

@rybarczykj
Copy link

none of the canvases at https://zenozeng.github.io/p5.js-svg/examples/ are rendering.

console errors say

VM419:2 Uncaught ReferenceError: SVG is not defined
    at setup (eval at req.onload (demo.js:31:9), <anonymous>:2:28)
    at p5._setup (p5.js:64079:27)
    at p5._start (p5.js:64002:25)
    at new p5 (p5.js:64355:22)
    at req.onload (demo.js:32:9)
@dkyy
Copy link

dkyy commented Apr 1, 2024

I'm having the same problem.

didny added a commit to nkymut/p5.js-svg that referenced this issue May 7, 2024
@didny
excempt dist/p5.svg.js from .gitignore fix:zenozeng#255
e1dde64
didny added a commit to nkymut/p5.js-svg that referenced this issue May 7, 2024
@didny
add to .gitignore fix:zenozeng#255
9742701
nkymut added a commit to nkymut/p5.js-svg that referenced this issue May 10, 2024
@nkymut
fix: p5.js@1.7.0+ (zenozeng#254,zenozeng#255,zenozeng#258)
a052366
@nkymut nkymut mentioned this issue May 10, 2024
Open
@pifragile
Copy link

i found this to be an issue with versioning. this setup worked for me:

  <script src="https://cdnjs.cloudflare.com/ajax/libs/p5.js/1.3.0/p5.min.js"></script>
  <script src="https://unpkg.com/p5.js-svg@1.3.1"></script>

nftbiker pushed a commit to nftbiker/p5.js-svg that referenced this issue Oct 15, 2024
@actions-user
Squashed commit of the following:
2cad96f 
commit d2003ab
Author: yuta nakayama <nkymut@gmail.com>
Date:   Sun May 12 19:31:15 2024 +0800

    update: rollup dependencies ver

commit 03e463d
Author: yuta nakayama <nkymut@gmail.com>
Date:   Sat May 11 08:29:59 2024 +0800

    fix: package.json

commit a052366
Author: nkymut <nkymut@gmail.com>
Date:   Fri May 10 14:09:30 2024 +0800

    fix: p5.js@1.7.0+ (zenozeng#254,zenozeng#255,zenozeng#258)

commit b59ef84
Author: nkymut <nkymut@gmail.com>
Date:   Fri May 10 11:41:21 2024 +0800

    fix: createGraphics@1.7.0+(zenozeng#254)

commit 9742701
Author: yuta nakayama (didny) <didny@nus.edu.sg>
Date:   Tue May 7 17:14:03 2024 +0800

    add to .gitignore fix:zenozeng#255

commit 7f79e7d
Author: yuta nakayama (didny) <didny@nus.edu.sg>
Date:   Tue May 7 17:03:36 2024 +0800

    fix typo

commit e1dde64
Author: yuta nakayama (didny) <didny@nus.edu.sg>
Date:   Tue May 7 16:59:11 2024 +0800

    excempt dist/p5.svg.js from .gitignore fix:zenozeng#255

commit 040bf76
Author: yuta nakayama (didny) <didny@nus.edu.sg>
Date:   Tue May 7 16:46:20 2024 +0800

    add dist

commit e9e0e5c
Merge: c71403f cf65a2f
Author: yuta nakayama (didny) <didny@nus.edu.sg>
Date:   Tue May 7 15:56:44 2024 +0800

    merge BL451 fix

commit c71403f
Author: yuta nakayama (didny) <didny@nus.edu.sg>
Date:   Tue May 7 15:40:57 2024 +0800

    update examples to 1.9.0

commit cf65a2f
Author: Benjamin Lappalainen <b.m.lappalainen@gmail.com>
Date:   Sat Mar 23 13:29:40 2024 -0400

    Fix compatibility with p5js 1.7.0+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dkyy @pifragile @rybarczykj