-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Symbol.for
to create Symbol.observable
if it does not exist.
#9
Conversation
This is the method used by `symbol-observable` and other packages (including RxJs/Observables). The current usage is causing false negatives from the `is-observable` package in latest Node.
Maybe |
That would probably be better. |
Oh dear. I considered recommending |
I like dependency-free : ) I'll comment over on symbol-observable. |
You could always just copy-paste it. I'm more concerned about consistent behavior. |
@zenparsing you might want to roll this one back, as it doesn't match prior art like Symbol.iterator === Symbol.for('iterator'); // false |
... or just use symbol-observable, as @sindresorhus suggested. lol |
I basically did. It just changed a day later |
Yeah, but which one is right? Who decides this stuff? It seems really important to get it right, better to do it now. Who pushed the Symbol spec through? Let's ask them. |
WRT
The TC39, after exhaustive discussion and debate, I suppose.
People like @zenparsing and friends. |
This is the method used by
symbol-observable
and other packages (including RxJs/Observables).The current usage is causing false negatives from the
is-observable
package in latest Node.