-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] ArraySubsetAssertion #14
Conversation
c4066c7
to
cfedeb5
Compare
cfedeb5
to
55b98b8
Compare
55b98b8
to
3a8e1c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like this implementation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add the not assertions to Expectation
: Expectation::notHasSubset()
& IsNotSubsetOf()
.
For allowing json strings, what about leaving ArraySubsetAssertion
as-is and having the Expectation method's allow json strings and decode?
1e9a8ed
to
20e09ec
Compare
done
I'd rather do it inside |
89fcd74
to
b1af4f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Just one small type check change.
Do you want to merge nikophil#1 into this PR or do it in a separate follow-up?
b1af4f6
to
2a5c835
Compare
No description provided.