Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of symfony/* dependencies #2295

Closed
Jeckerson opened this issue Oct 1, 2021 · 2 comments · Fixed by #2319
Closed

Get rid of symfony/* dependencies #2295

Jeckerson opened this issue Oct 1, 2021 · 2 comments · Fixed by #2319
Assignees
Labels
enhancement Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details

Comments

@Jeckerson
Copy link
Member

Every release we are blocked due some external packages that are on their own mind when to support next version of PHP. Same occurred with PHP8.0, in which we needed to shift minimal support of Zephir to PHP7.4.

Implement own simple solutions for CLI, DI and logs in Zephir and get rid of next packages:

  • symfony/console
  • symfony/framework-bundle
  • symfony/monolog-bridge
  • symfony/monolog-bundle
  • symfony/yaml
@Jeckerson Jeckerson added this to the 0.15.0 milestone Oct 1, 2021
@Jeckerson Jeckerson self-assigned this Oct 1, 2021
This was referenced Oct 1, 2021
@StudioMaX
Copy link

Symfony has been supporting PHP 8.1 in their CI since version 5.3.7 which was released in August, isn't it? Symfony 5.2 is already EOL since July 2021.

@Jeckerson
Copy link
Member Author

Jeckerson commented Oct 2, 2021

@StudioMaX tl;dr: It doesn't matter, "writing for PHP in PHP is utopia", especially when there alot of external dependencies in your composer.json. Zephir itself must be maximum abstract in that terms, in what it really might and can depend are PHP extensions.

Long description about PHP8.1 support:
image

"name": "symfony/framework-bundle",
"version": "v5.3.8",

This occur because symfony removes comments about deprecation notice (#[ReturnTypeWillChange]) when it caches PHP files...

I tried to configure the configuration file from yaml to PHP, but their logic seem to differ...

return function (ContainerConfigurator $configurator) {

So also no luck.

P.S. Packages mentioned above are last peace for little bit more liberty in terms of faster support of new version of PHP in Zephir, because Zephir Parser is already ready to go in both: PHP8.1 and PHP8.2 versions.

P.P.S. Zephir does not need any complex libraries to make its job: read AST array from parser and generate correct C code, then execute compilation commands to create PHP compatible extension.

@Jeckerson Jeckerson added the Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details label Oct 3, 2021
@Jeckerson Jeckerson removed their assignment Oct 3, 2021
@Jeckerson Jeckerson modified the milestones: 0.15.0, Backlog Oct 5, 2021
@Jeckerson Jeckerson self-assigned this Oct 24, 2021
@Jeckerson Jeckerson removed this from the Backlog milestone Oct 24, 2021
Jeckerson added a commit that referenced this issue Oct 24, 2021
* `symfony/framework-bundle`
* `symfony/monolog-bridge`
* `symfony/monolog-bundle`
* `symfony/yaml`
@Jeckerson Jeckerson linked a pull request Oct 24, 2021 that will close this issue
3 tasks
Jeckerson added a commit that referenced this issue Oct 24, 2021
Jeckerson added a commit that referenced this issue Oct 24, 2021
Jeckerson added a commit that referenced this issue Oct 24, 2021
Jeckerson added a commit that referenced this issue Oct 24, 2021
Jeckerson added a commit that referenced this issue Oct 24, 2021
@Jeckerson Jeckerson reopened this Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants