Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] Add support of MAY_BE_STRING|MAY_BE_FALSE #2338

Closed
Jeckerson opened this issue Jan 13, 2022 · 1 comment · Fixed by #2358
Closed

[NFR] Add support of MAY_BE_STRING|MAY_BE_FALSE #2338

Jeckerson opened this issue Jan 13, 2022 · 1 comment · Fixed by #2358
Assignees
Labels
enhancement nfr New Feature Request

Comments

@Jeckerson
Copy link
Member

Jeckerson commented Jan 13, 2022

Deprecated: Return type of Phalcon\Session\Adapter\Noop::gc(int $maxlifetime) should either be compatible with SessionHandlerInterface::gc(int $max_lifetime): int|false

Make possible to pass these kind of multiple types and generate correct Zend code.

@Jeckerson Jeckerson self-assigned this Jan 13, 2022
@Jeckerson Jeckerson added the nfr New Feature Request label Jan 13, 2022
@Jeckerson Jeckerson changed the title Add support of MAY_BE_STRING|MAY_BE_FALSE [NFR] Add support of MAY_BE_STRING|MAY_BE_FALSE Jan 13, 2022
@Jeckerson
Copy link
Member Author

Jeckerson commented Feb 7, 2022

Blocked by zephir-lang/php-zephir-parser#137

Jeckerson added a commit that referenced this issue Feb 27, 2022
Jeckerson added a commit that referenced this issue Feb 27, 2022
Jeckerson added a commit that referenced this issue Feb 27, 2022
Jeckerson added a commit that referenced this issue Feb 27, 2022
Jeckerson added a commit that referenced this issue Feb 27, 2022
Jeckerson added a commit that referenced this issue Feb 27, 2022
Jeckerson added a commit that referenced this issue Mar 19, 2022
@Jeckerson Jeckerson linked a pull request Mar 19, 2022 that will close this issue
3 tasks
Jeckerson added a commit that referenced this issue Mar 19, 2022
Jeckerson added a commit that referenced this issue Mar 19, 2022
Jeckerson added a commit that referenced this issue Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement nfr New Feature Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant